This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: allow users to select PVA topics when beginning new dialog#6691
Merged
a-b-r-o-w-n merged 28 commits intomainfrom Apr 14, 2021
Merged
feat: allow users to select PVA topics when beginning new dialog#6691a-b-r-o-w-n merged 28 commits intomainfrom
a-b-r-o-w-n merged 28 commits intomainfrom
Conversation
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
There has been a change in how content diff is calculated that no longer requires this.
a-b-r-o-w-n
commented
Apr 6, 2021
| export const DialogRef: WidgetComponent<DialogRefCardProps> = ({ id, onEvent, dialog }) => { | ||
| export const DialogRef: WidgetComponent<DialogRefCardProps> = ({ id, onEvent, dialog, data }) => { | ||
| const { ElementWrapper } = useContext(RendererContext); | ||
| const { dialogs, topics } = useContext(NodeRendererContext); |
Contributor
Author
There was a problem hiding this comment.
@yeze322 Can you take a look at this and let me know your thoughts?
I wanted to do 2 things:
- Use the dialog's display name instead of its id
- Differentiate from dialogs and topics
This is your domain so I want to make sure that this approach is fine, or work with you to do something better.
tonyanziano
reviewed
Apr 13, 2021
| const isRoot = file.relativePath.includes('/') === false; // root dialog should be in root path | ||
| const dialog: DialogInfo = { | ||
| isRoot, | ||
| isTopic: file.relativePath.startsWith('topics/'), |
Contributor
There was a problem hiding this comment.
I think the answer is yes, but just confirming: We are fine with not indexing the topic if the user decides to muck around with the folder structure right?
Contributor
Author
There was a problem hiding this comment.
We should engage the PVA team on that. My assumption is that the folder structure is necessary when publishing back to PVA, but I don't know for sure.
tonyanziano
reviewed
Apr 13, 2021
Composer/packages/server/src/externalContentProvider/powerVirtualAgentsProvider.ts
Show resolved
Hide resolved
tonyanziano
reviewed
Apr 13, 2021
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
LGTM but going to wait until Ze responds to your comment before approving.
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…rosoft#6691) * add includeTopics query when downloading bot content * include topics when loading bots * do not show topics in the main dialog navigation * move icons into shared * add more icons * add isTopic to DialogInfo * expose topics through shell api * show topics in begin dialog action * link to PVA topic * include pva topics by default for electron task * update query string to be boolean value * do not include etag when publishing with topics There has been a change in how content diff is calculated that no longer requires this. * make icons in dropdowns blue * revert If-Match header change Bug was fixed in PVA * default to using oneauth in electron launch task * silence console output for tests in CI * fix select dialog test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task Item
refs #6047
Screenshots